Kevin Bond

Results 420 comments of Kevin Bond

As an interim solution, what about an `always_public` `HttpCache` option that, when true, never sets the response to private?

I discovered that if we avoid calling this line: https://github.com/symfony/symfony/blob/c2af1fd78e5085cd72f554f0fd79ec62d4d60a0e/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L517 It allows caching responses even when `cache-control: private`. My proposal suggests a way to configure so this line is never...

I could use some advise on how to create a deprecation layer for this. To avoid a BC break, `Request::$request` and `Request::$form` must reference the same `InputBag` instance. Also, since...

FYI, I chose `$form` because this is what `$_POST` represents, [the _form data_](https://www.php.net/manual/en/reserved.variables.post.php). I'm not completely convinced that `$form` is the best term (it's better than `$request` IMO) - maybe...

> Personally don't think its worth renaming this. This will be a hard break for a lot of Systems, which tries in the past supporting multiple Symfony versions. This is...

@symfony/mergers any thoughts on this. I really like the idea. I think it's common to want to get the array of data from a request and not care if it's...

This issue has sort of morphed into three things. 1. A new property (`$body`) that represents either the `$_POST` data or json request body (the initial part of this issue)....

> My preference goes for body, I think it's the the most consistent with PHP and HTTP terms: Now, do you think `$body` should be `new InputBag($_POST ?: $this->toArray())` as...

@ostrolucky, if types can be services, how could we allow arguments if `Type::__construct()` [cannot be overriden](https://github.com/doctrine/dbal/blob/8532d4942c2b1565ad27a211966ede334d68d5f1/src/Types/Type.php#L56)?