Kevin Bond

Results 420 comments of Kevin Bond

Hey! > One idea I heard was that we could just use foundry to create the necessary classes and then remove the library again. Would that even be possible? No,...

Thanks for fixing this @NorthBlue333! To clarify, you are describing two separate issues here? 1. A polymorphic relationship with a mapped super class? This PR fixes this? 2. Creating a...

> I will create a separate PR/issue Ok perfect, that would be best. For this PR, just create the entities that demonstrate the need for the fix you made.

Hey @NorthBlue333, let me know when you've gone as far as you can, then I can fix up the tests.

I don't think the tests actually are covering this fix. I pushed a temporary commit to remove the fix and all the tests still pass.

So if we re-add the fix, the test suite will pass? > Needs https://github.com/zenstruck/foundry/pull/302 for all tests to be ok. Should we merge that one first?

> I do not really know if this is intended, and there are no tests asserting this behavior. Could you state if these tests are necessary? Hmm, this was not...

Looks like we're all good here. Ok to merge after the final action completes? Question: did you ever get the tests running locally?