Kevin Bond comments

Results 589 comments of


                                            Kevin Bond

Add CI workflow to compute diff between files dist files

Shouldn't this job only run if a dist file has been changed?

Add CI workflow to compute diff between files dist files

This looks great! @Kocal: 1. Can you revert the temporary commit? 2. The proper permissions are still todo?

Introduce cookbook documentation

Thanks Matheo.

Missmatch between PHPDoc and the reality on User::getRoles()

Thanks for digging into this @Curryed. What about removing the `@return` docblock and just letting the `UserInterface` dictate? I typically never override docblocks from interfaces/abstract classes (unless required) but maybe...

Missmatch between PHPDoc and the reality on User::getRoles()

Thank you @Curryed.

doc: notes/tips for `foundry:load-stories`

Yep, I'll do this!

[Translator] Add configuration to filter dumped translations by domain

This is great @maelanleborgne, thank you!

Mistaken error 'If condition is always true.' with goto

I discovered another issue with `goto` - only fix I've found is switching to `while(true)`: Error: https://phpstan.org/r/85901590-3793-4dd8-aea7-d36c40a085e2 Fixed: https://phpstan.org/r/ec190637-4e58-4e1e-a18a-d7b740f472c9

`tailwind.config.js` always used with `tailwind:build`

Oops, yeah I missed removing that in v4 - does it actually create an error?

`tailwind.config.js` always used with `tailwind:build`

> No, this does not create any errors. That's good at least but still, we'll get it removed when TailwindCSS >= 4.