ux icon indicating copy to clipboard operation
ux copied to clipboard

[Translator] Add configuration to filter dumped translations by domain

Open maelanleborgne opened this issue 1 year ago • 5 comments

Q A
Bug fix? no
New feature? yes
Issues Fix #1225
License MIT

Add two config entries included_domains and excluded_domains to filter which translation domains should be dumped. If included_domains is empty, it is not taken into account.

TODO:

  • [ ] Add entry to changelog

maelanleborgne avatar Jun 20 '24 08:06 maelanleborgne

So were are we there ? :) Do you need help for something ? Is the doc ready ?

smnandre avatar Jun 25 '24 20:06 smnandre

So were are we there ? :) Do you need help for something ? Is the doc ready ?

@smnandre Yes that should be it, the doc as well. I'm just not sure what version I should use in the changelog entry.

maelanleborgne avatar Jun 26 '24 07:06 maelanleborgne

2.19 no ?

smnandre avatar Jun 26 '24 07:06 smnandre

The failing test surprises me a bit ... @WebMamba any idea ? I feel we may have exposed more than we wanted

smnandre avatar Jun 27 '24 05:06 smnandre

Looks like this is related to the PR: https://github.com/symfony/ux/pull/1940.

Hummm the test looks flaky. I don't think this is related to this PR though

WebMamba avatar Jun 27 '24 07:06 WebMamba

This is great @maelanleborgne, thank you!

kbond avatar Jul 18 '24 12:07 kbond