Krzysztof Bieganski

Results 89 comments of Krzysztof Bieganski

[Here's a thread sanitizer log of BlackParrot GRT on `master`](https://github.com/The-OpenROAD-Project/OpenSTA/files/14872299/tsan.log) Example warning: ``` WARNING: ThreadSanitizer: data race (pid=709934) Write of size 4 at 0x7b880057571c by thread T6 (mutexes: write M0):...

@osamahammad21 Have you had a chance to look at this?

I think each `switch` is a mix of checked and unchecked accesses (the `*Fixed*` ones are checked, the `*Route*` ones aren't). For example, see [this part](https://github.com/The-OpenROAD-Project/OpenROAD/pull/5913/files#diff-3b0ee5af511f4838323555d94ad93cc7da9df71a64bf049fa6b634da77978e64L84-R85) which calls [this function](https://github.com/The-OpenROAD-Project/OpenROAD/pull/5913/files#diff-a62f2dab4026966036f9855039c60b6de4b6f462499a04b0043890390288d668L555-R558)....

@osamahammad21 In case you missed it

If the purpose of this repo is to have users clone it and use it for their projects with Verilator, then for sure we should switch to what you propose....

This is, in fact, due to Verilator treating `

This patch: ```diff diff --git i/src/V3Active.cpp w/src/V3Active.cpp index 6c6070574..4ac69da3d 100644 --- i/src/V3Active.cpp +++ w/src/V3Active.cpp @@ -362,6 +362,7 @@ private: // Issue appropriate warning if (m_check == CT_INITIAL) { + if...