Krzysztof Bieganski

Results 87 comments of Krzysztof Bieganski

Note that Verilator 5 no longer uses `shared_ptr` (https://github.com/verilator/verilator/pull/3595). Now there's a custom intrusive pointer (`VlClassRef`) which can be created from `this`, as it stores the ref count within the...

> I think I'd name the files just e.g. V3Dynamic etc and drop the Scheduling. Likewise --dynamic. I'm open to changing the name, but is `Dynamic` alone the best option?...

I quite like "timing," actually. "Coroutines" is an implementation detail and it doesn't tell the user much. If we have other implementations in the future we could add that as...

I applied your suggestions. I haven't separated any pre-PRs yet, I'll do that soon (I assume you still want those on `master`, not on that V5 branch which we discussed).

Added `//verilator timing_off` and `//verilator timing_on`. Timing is on by default. Renamed `V3Dynamic` to `V3Timing`, as well as all the related stuff accordingly. Re-did `V3DynamicClass`, now it's part of the...

> > I guess we also need a global --timing-off/--no-timing flag? > > Yes, I think a --no-timing. > Wouldn't it be better to use the same wording as the...

> I don't understand your "Can't really make it work"? I meant that using `--no-timing` as a pragma looks bad (e.g. `/*verilator no_timing_on*/`). Doesn't matter, as we want it to...

I think I addressed all of your concerns. @wsnyder what is the state of your review? Should I start making pre-pull requests? If so, should they target `master` or the...

> I'm not sure if github will accept changing what branch it is against but is worth a try I'm pretty sure we'll need a new PR. I'll start opening...

Adjusted timing support to the Verilator 5 branch. Most of it has pretty much been rewritten. I changed the PR description to reflect it. I'm not happy with everything yet,...