pýrus

client: add InitConn method

4

`InitConn()` method allows to set the client's connection after the `smtp.Client` variable initialization with custom timeouts. resolves #175

Auth is ignored in the master branch

3

@foxcpp the #146 PR introduced a breaking change. While adapting my code to meet the recent package requirements I noticed that AUTH can be ignored. A simple server code [example](https://github.com/emersion/go-smtp#server)...

server: Impossible to disable PLAIN auth

1

PLAIN auth is enabled by default and it is not possible to disable it: https://github.com/emersion/go-smtp/blob/30169acc42e795e5d35ce901c8387950b103dfd9/server.go#L86-L87 it also doesn't look correct that `Session` interface now requires the `AuthPlain` method (#146). Why...

There is only one way to initialize an SMTP client: `NewClient` function. This function doesn't allow to set greetings timeout and it has hardcoded 5 minutes timeout, even if the...

Add ServerDomain member into the ConnectionState struct

2

Add server's hostname (domain) into the `ConnectionState` struct. It can be used for logging purposes.

server: handleConn's return error cannot be catched

4

There there is no way to catch errors, returned by handleConn method: https://github.com/emersion/go-smtp/blob/30169acc42e795e5d35ce901c8387950b103dfd9/server.go#L124 https://github.com/emersion/go-smtp/blob/30169acc42e795e5d35ce901c8387950b103dfd9/server.go#L128

Distinguish server and client debug logs

2

Currently the debug mode writes all the input and output into one stream: https://github.com/emersion/go-smtp/blob/26eb4814e227ff64ec3316910eb0b4e357e6e4e7/conn.go#L84-L85 I'd like to have independent debug streams and alternatively skip or mask `AUTH` command details. Probably...

related to https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/issues/41 maybe this comment can fix the issue: https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/commit/c9fa728f1a626d261d8625c527df1b166278c653#diff-83453022bdb83378e6c454e99caacd36 thus I have to verify whether plugin version bump will help

`--register-schedulable` will be deprecated and replaced with `--register-with-taints=node.alpha.kubernetes.io/ismaster=:NoSchedule` https://github.com/kubernetes/kubernetes/pull/31647

unit: try to avoid unit file modification

1

@jonboulle it still skips commented strings, not sure how can I implement that... main goal is to keep unit files unmodified when it is possible. resolves https://github.com/coreos/fleet/issues/1539