KC Sivaramakrishnan

We should keep this issue open. The fixes to these issues will be breaking changes and hence I sense a general hesitation to start working on a solution.

I'm starting to review this PR, but I have a couple of difficulties in the way this PR and others like #11307 are organised which is making it harder for...

Except for this one comment on the second commit (https://github.com/ocaml/ocaml/pull/11386/commits/142beb885999e07d5273fb8958811e5c077b0e9b#r1207685036), the other changes look fine to me.

> As I understand it, this is not scheduled for 5.1 so there is no rush. It would be useful to get this towards a merge soon as the code...

> Except for this one comment on the second commit (https://github.com/ocaml/ocaml/commit/142beb885999e07d5273fb8958811e5c077b0e9b#r1207685036), the other changes look fine to me. Force push lost my comment ?! :-( I don't know what my...

> Let me know about the last point, and then I will clean-up the PR. LGTM. Please also add a changes entry. I'll aim to merge this right after that.

> Thanks @kayceesrk for having a look. I have seen your question about a minimal fix for 5.1; I'll answer shortly. Thanks a minimal fix would be incredibly useful.

On my Mac, `make` succeeds without a failure both on `5.0.0` and `5.1.0~rc3`. Can you make sure your opam switch is set up right? It may just be a matter...

Threads tests have been fixed by https://github.com/ocamllabs/ocaml-effects/commit/47a2fcbcefe21e2e73929acf5beb9a91780940ef.

@gadmm I've left a review for #11386. > the problems with Domain.spawn are possibly worse I've responded here: https://github.com/ocaml/ocaml/pull/11386#discussion_r1207665739. As I've commented at https://github.com/ocaml/ocaml/pull/11386#issuecomment-1565190046, it would be best to have...