Kane Valentine

Results 26 comments of Kane Valentine

I've pushed another commit, ccaacf5 - which was a change already proposed as part of PR #134. Figured we could hopefully kill many birds with one stone.

@rmm5t thank you for informing me of this, I simply based my commit from your earlier PR without checking Docker Hub for updated information. Perhaps it would be best for...

I've made some more pushes with some general quality of life improvements to the `Dockerfile`, such as using `COPY` instead of `ADD` as suggested by Docker Captain @bretfisher! :)

Bump! Anyone with merge powers able to check this over? :)

_Screams into cyberspace, but no one hears._

This is possibly on our roadmap for future versions, in the meantime you should checkout @MattRogowski's CookieLaw plugin: https://github.com/MattRogowski/Cookie-Law/

Also, is there an environment variable to allow me to change the websocket port used by the app? In the `docker-compose.yml` file I can easily change the websocket listener like...

>Currently not. >It is a good idea to make ports configurable. >Would you like to make a PR or shall I do it for you? Hmm, I assume that it...

@ohtake thank you! I have tested it and the fuctionality works as intended. :slightly_smiling_face:

I'm not sure if this is somewhere we can suggest editors but my vote goes for Monaco: https://microsoft.github.io/monaco-editor/