Kavin Ruengprateepsang
Kavin Ruengprateepsang
@toasted-nutbread I've roughly tested a speculation of the bug on sending/listening messages in Safari. At least, [`chrome.runtime.sendMessage`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/background/backend.js#L1589) seems to work fine and can be received by [`chrome.runtime.onMessage.addListener`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/comm/frame-client.js#L153) in Yomichan. The...
@toasted-nutbread Ah, yeah, it really stuck at [` await yomichan.prepare()`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/display/popup-main.js#L32). Therefore, [`yomichan.api.broadcastTab('frameEndpointReady', {secret: this._secret});`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/comm/frame-endpoint.js#L31) cannot be reached. That's why [`frameEndpointReady`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/comm/frame-client.js#L90) action never executed, so does [`frameEndpointConnected`](https://github.com/FooSoft/yomichan/blob/0556c503195fb274069817514ceaad9ed2f1c998/ext/js/comm/frame-client.js#L98). Thus, the promise is...
I'm only guessing, but the existing problem is deemed to be the top of the iceberg? Not really sure how many problems actually exists. I know that Yomichan is much...
I'd love having typed subparsers as well, but I have another opinion a bit different from @pvalsecc regarding the type: > ```python > a: Optional[SubparserA] > b: Optional[SubparserB] > ```...