ldap-groups icon indicating copy to clipboard operation
ldap-groups copied to clipboard

fixed get_descendants

Open fedorareis opened this issue 6 years ago • 1 comments

Currently get_descendants only returns itself. I made get_desendants behave more like get_tree_members which means it now returns all groups that are lower on the tree than the parent.

One other thing to note is that I also swapped out the search for get_children. The new search means the result list no longer needs to be built manually, let me know what your thoughts are on that change. I can revert it to the previous method or I can go through and update all of the functions to use the new search method.

fedorareis avatar Apr 21 '18 03:04 fedorareis

Codecov Report

Merging #7 into master will decrease coverage by 1.04%. The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   21.92%   20.87%   -1.05%     
==========================================
  Files           3        3              
  Lines         260      273      +13     
  Branches       48       50       +2     
==========================================
  Hits           57       57              
- Misses        203      216      +13
Impacted Files Coverage Δ
ldap_groups/groups.py 13.94% <5.55%> (-0.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0dd3a7d...1a9a2bc. Read the comment docs.

codecov[bot] avatar Apr 21 '18 03:04 codecov[bot]