Kasper Timm Hansen

Results 119 comments of Kasper Timm Hansen

Here's a fresh clone without having done `bundle install; yarn install; bin/dev` and it looks like it's already running `javascript:build` automatically: ``` 3.2.1 ~/code/bullet-train-co/starter main = bin/rails test:system ^Crails aborted!...

hm, in the clone ^ with node v19.7.0 `yarn install` doesn't print anything in my terminal and seemingly just takes forever. Cool.

Ok, I just made another clone. If I run `nodenv local 19.3.0` first, then `bin/rails test:system` works flawlessly. It runs `yarn install` and compiles assets — and the system tests...

@KonnorRogers thank you for chiming in here! It helped me figure out how to investigate this a little more.

By letting `device_name` and `display_details` become instance state, this could also open the door to clearer abstractions ala: ```ruby def device @device ||= Device.new(device_name, **display_details) end class Device def initialize(name,...

Here's what I'm thinking for the update sequence: 1. I can remove the changes to the specific test file here, then users have got the `device_test` helper and they can...

@jagthedrummer what's the upgrading guide, this one? https://bullettrain.co/docs/upgrades — that seems to target the surface level, but ideally we'd want something more like a changelog.

@jagthedrummer I'm going to be working on the update script for this now. Now that you've setup GitHub releases for Bullet Train, how do I use that to communicate what...

Added a script, but my system tests fail locally, I have to go, but I'll come back and run them on CI later.

> Our ultimate goal isn't so much to land this PR (which is definitely a good and helpful PR, don't get me wrong). The ultimate goal is to be able...