Kasper Timm Hansen

Results 9 comments of Kasper Timm Hansen

I still like @georgeclaghorn's idea of a separate ConfirmationsController. I also think that would force us to consider a model extraction. Here's my take on that. ```ruby # frozen_string_literal: true...

> One minor point is that I think @georgeclaghorn suggested separate actions and not necessarily controllers (unless I have missed a message). George suggested a separate controller in https://github.com/rails/rails/pull/39364#discussion_r428997727 that's...

> After: gel install 354s (this PR) Wow, that sounds pretty slow still! Curious if there's any other leads as to why this grinds?

Wanted to see the runtime for myself so tried testing the Gemfile locally with @matthewd's commit on top and I get a RuntimeError. I'm assuming there's a Gem I don't...

Ah, cool! If I just use `github: "bkeepers/dotenv"` (well, `git:` but you get the idea) now it works and was fairly snappy actually. But I don't see Action Pack or...

It would be easier to discuss this if you open a new Pull Request and reference this issue :) ## Kasper > Den 09/02/2015 kl. 05.32 skrev Hong Chulju [email protected]:...

I haven't looked too closely at this yet, but it looks like there's an official `setup-node` action, which has yarn support https://github.com/marketplace/actions/setup-node-js-environment I think we'll be better off using that...

Looks like the tree-sitter grammar for Slim is here https://github.com/kolen/tree-sitter-slim