Kasper Svendsen
Kasper Svendsen
Official support for type hierarchies was added in [LSP v. 3.17](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareTypeHierarchy).
> I think @kaspersv determined that pragma[nomagic] isn't needed on any of the predicates. It was only needed in an early compiler prototype. Is that right, Kasper? Yes, that is...
> This is currently a fairly incomplete heuristic (there are other places that invoke global data flow), but I guess this provides a decent enough starting point and that further...
@hvitved @tausbn Would you mind reviewing the C# and Python parts of this PR ([commit 2](https://github.com/github/codeql/pull/19779/commits/d0feec9168ae9bf9dd31a42397eb258eb16ceddb))? The PR adds overlay annotations for Java, but since we still have a few...
@aschackmull We ended up renaming the previous [`overlay[caller]` annotation to `overlay[caller?]`](https://github.com/github/codeql-core/issues/4975). As a result, I've added a third commit that renames all `overlay[caller]` annotations to `overlay[caller?]`. Commits 1 and 2...
Merged in `main` to resolve a merge conflict with the recently merged shared Guards library. Needed one additional overlay annotation in the shared Guards library.
The failing [Code scanning results / CodeQL](https://github.com/github/codeql/pull/19779/checks?check_run_id=44842287173) CI check indicates the PR introduces two new QL4QL alerts classified as errors, but only lists [one](https://github.com/github/codeql/security/code-scanning/95681), concerning naming of a predicate argument...
@ginsbach I've updated the script to add overlay annotations with a `--check` mode (to be used by the [CI check](https://github.com/github/codeql/pull/19780)) and expanded the script such that it can handle all...
> What about inline_late? The reason predicates annotated with `pragma[inline]` need `overlay[caller]` annotations is that `pragma` annotations are not supposed to affect semantics and under overlay evaluation inlining across the...
@ginsbach I've rebased the PR and added the third commit which renames `overlay[caller]` to `overlay[caller?]`. Commits 1 and 2 haven't been modified since the last review.