Kacper Michajłow

Results 582 comments of Kacper Michajłow

We can always have additional flag to mark options like that. But I would say it's low-priority.

> Thanks. That fixes it. Why is it not the default?

> when is this a bottleneck?? I agree, we should evaluate whether it is needed using some test cases that show the actual difference. mpv, under normal operation, shouldn't spawn...

I think most if not all flags would be safe to use. For `-ffinite-math-only` it mostly means we have to be careful about dividing by zero, which is most common...

> The largest difference is surprising: the compiler seems to be much less aggressive about inlining floating-point math routines, and inserts calls to isnan where they'd otherwise have been optimized...

On x86 at least it is compiled directly to ``` c double foo(double a, double b) { return ((a) > (b) ? (a) : (b)); } ``` ``` asm foo:...

> But I don’t think “libass depends on NaNs for correctness” is an accurate statement I agree. I only mentioned it before, because there are `isnan` checks, which would be...

You need to install and use font that supports all the glyphs. There are multiple ``` [sub/ass] Glyph 0x... not found, selecting one more font for (sans-serif, 400, 0) ```...

It wouldn't be possible in config. But it should be possible to make lua script that checks subtitle track langauge and set the font accordingly. I don't have time rn...

It works well with this branch on oss-fuzz side https://github.com/kasper93/oss-fuzz/tree/add_libass_msan One remaining item to discuss is what fonts to include in the build. With that added, libass should be fully...