Kacper Michajłow

Results 567 comments of Kacper Michajłow

I'm not sure if libplacebo should ever select pass-through on it's own. But this has not been fixed yet.

Why does it pick `VK_COLOR_SPACE_PASS_THROUGH_EXT` if it has so many valid choices? I would check that, because disabling pass_through may only hide underlying selection issue.

Well if there is no colorspace hint, pass throguh is arguably correct choice. Send whatever we render to whatever is configured in system and it's on user to configure both...

> VK_COLOR_SPACE_PASS_THROUGH_EXT's behavior is completely unknown I don't agree on that. It simply means, don't set the colorspace. It depends on the rest of the system configuration, from libplacebo it...

I was fixing ICC profile issue, and I came to realization that when we use target ICC profile ourselves we should also use `VK_COLOR_SPACE_PASS_THROUGH_EXT` which would match macOS expectation of...

You need to remember that Vulkan is not Wayland and Wayland limitations should not be transferred implicitly to Vulkan implementation, especially that it is completely agnostic of that. Conceptually when...

It's a matter of choosing the best output for our usecase. And this is what we want. If it doesn't work, no other colorspace would work either. And user can...

> To achieve pass through on wayland, you set the color description to the preferred color description. At least for opaque surfaces, the buffer should then be passed on to...

> Either way, there is no way to do this from vulkan. The code that deals with vulkan and the code that deals with wayland need to negotiate that the...

> > I don't know exactly what information ICC profiles contain, but have you considered transforming the video data according to the ICC profile to the next-larger vulkan color space...