Kaspar Schleiser

Results 159 comments of Kaspar Schleiser

Would a range dependency for `embassy-executor` work? `>=0.7,

> So for example if your root crate depends on embassy-executor 0.8, embedded-test would bring in embassy-executor 0.7. Ah, right. :/ It doesn't seem to do that in every case....

> It doesn't seem to do that in every case. Maybe because I have a Cargo.lock. 🤦

Maybe it is just never correct to have multiple embassy-executor versions, and upstream should add some "link=i_am_the_only_one". Maybe in that case, Cargo would not chose multiple versions but one that...

> Does that sound acceptable? That's essentially what I'm doing manually now, and does sound acceptable. Would it be possible to rotate only those runners that have changed any options?

Great, thanks already for thinking this through!

This is an issue also in other parts of core, e.g., in [core/mutex](https://github.com/RIOT-OS/RIOT/blob/e5c185b9ebf9054f100092eee19cd7954f8d884b/core/mutex.c#L90-L92) and [msg](https://github.com/RIOT-OS/RIOT/blob/e5c185b9ebf9054f100092eee19cd7954f8d884b/core/msg.c#L162-L163).

> My suggestion is to always assume interrupts are enabled. I think this makes the most sense.

> > This is an issue also in other parts of core, e.g., in [core/mutex](https://github.com/RIOT-OS/RIOT/blob/e5c185b9ebf9054f100092eee19cd7954f8d884b/core/mutex.c#L90-L92) and [msg](https://github.com/RIOT-OS/RIOT/blob/e5c185b9ebf9054f100092eee19cd7954f8d884b/core/msg.c#L162-L163). > > Indeed, and it seems the fix is the same everywhere. Probably...