Karun Shrestha

Results 11 comments of Karun Shrestha

> The condition you added is not quite right. The problem is that you are using the check for `setCursor` as a stand-in for a page refresh. However, there are...

> That complicates things. I think we need to address the grouping issue first without the complication of undoing a null cursor. Will you create a separate issue for the...

> > When you say grouping issue, i am having a little confusion to understand what it exactly means, firstly. > > > > - Navigation actions immediately *after* the...

> Thanks! It looks like the new puppeteer test is failing. Could you investigate? I haven't found out what actually caused the test to fail for the first time but...

> The test failed in 2/3 runs, so we'll need to make it more reliable before merging it into `main`. We don't want to add any other flaky tests. Indeed,...

https://github.com/cybersemics/em/issues/3100 is occurring frequently in almost all new PRs not just in CI but also locally

FYI an update, did a loads of research and experimental testing for fixing caret flakiness issue. I think we will need to carefully consider the use of selection api which...

> Single line url test appears to be flaky, too. > > Temporarily skipped in [dde883c](https://github.com/cybersemics/em/commit/dde883c1a7b837134e0c2ac55295f253b0595770). This has been already addressed in this [PR](https://github.com/cybersemics/em/pull/3126/files#diff-a5b3a5ecfe3187d053ad665ca3ffed088c1d558c2b622af0f7324dfeafe87494R36-R39)

### Update: 1. Removed `clip-path` and `lineHeightOverlap` calculations as they are no longer needed. Previously, it was believed that the issue was just within 1px of top and bottom edges...