Karol Kokoszka

Results 12 comments of Karol Kokoszka

/cmd prdoc --audience runtime_dev --bump major

> > We're still in the QA period for stable2512, so we should revert it while we figure this out > > Unrelated/orthogonal: (in case of reverting [#9842](https://github.com/paritytech/polkadot-sdk/pull/9842), probably does...

I think the biggest pain is that Asset sorting rules are accidental / low-level / non-intuitive (basically sorting the XCM Locations) and specification will be probably long enough that every...

> Or exposing a runtime API for sorting assets True, I haven't think of this, but maybe this is a good compromise vs breaking API changes etc. My plan is...

Speaking in general, I can only see the requirement of sorting required for: - optimized search for duplicate items - usage of data structures like `pub fungible: BTreeMap,` that internally...

Thank you all for the discussion and glad we are on the same page - we all agree we need to fix this, just the timeline for stable2512 is too...

> Gentle ping — could we get the second review here? @bkontur @karolk91? @aleGiannini sorry for the delay on my side - I will provide my review early next week

@bkontur, @seadanda Is there anything I should do with this PR ? I can see some CIs failing but I believe this is because of base branch

@seadanda , @bkontur , @ggwpez I have synced with `donal-ahm` and removed `ah_can_transact_as_root_on_relay_chain`. Introduced proper tests utilizing `authorize_upgrade` extrinsics for all chains that replaces the test I removed. This branch...