Karel Minarik

Results 204 comments of Karel Minarik

Tire shouldn't overload any defined methods, see the source, could you post relevant parts of your models? On Tuesday, 9. July 2013 at 18:33, Hugh Brock wrote: > Hmm... what...

Strange, ActiveRecord attributes should be defined as regular methods; will investigate it further later. On Tuesday, 9. July 2013 at 18:51, Hugh Brock wrote: > Sure... > `So I have...

Been digging a bit into this, and seems like ActiveRecord is using some [`module_eval`](https://github.com/rails/rails/blob/master/activerecord/lib/active_record/attribute_methods/read.rb), which might throw Tire off, when it [looks for the method being already defined](https://github.com/karmi/tire/blob/master/lib/tire/model/search.rb#L297). I can...

Does this exception appear when using Faraday? Since `Resolv` is not loaded automatically by Ruby?

I understand the picture, I'm just wary about rescuing generic `Exception` in the code in question... But if we want to 100% cover theses cases, there might not be any...

> In other words turning off the automatic index creation. But that is problematic in its own sense: you set up your index settings and mappings in Tire, and you...

There's actually _another_ discussion about this in #798, and I like the proposed solution of `mapping(auto_create: false)`, since it's more fine-grained?

@threez Actually, if I understand your concern, the `action.auto_create_index: false` should be used in production, indeed. I'm leaning towards closing this issue in favour fo the suggestion of #798 by...

@fgrehm Sounds like a nice idea, but could you please add a more fleshed out example?

Will have a look. At the moment, the biggest problem is related to #767, and with the current release of Rails 4, the problem is more imminent.