Karel Minarik

Results 204 comments of Karel Minarik

Hi, thanks! I tried to make the adapter compatible with newer Ember Data versions recently, but failed, couldn't get the test suite to run. I'll try to look into this...

It's basically a boolean query with many `musts`s -- see https://github.com/karmi/tire/blob/master/test/integration/boolean_queries_test.rb For filters, just use the `or` filter, https://github.com/karmi/tire/blob/master/test/integration/filters_test.rb#L39-L40

Hi @steverob, yes, that might well be, I don't even remember the repository :) I'd like to help you, but it's really ancient, I think you'll have to dig yourself...

@steverob Still using Rails for sure! :)

Hi, absolutely right. The `after_commit` / `after_rollback` hooks are ActiveRecord specific, so we must take care here. Since the callback integration is very simple, I think we can add it...

@tmaier Look at #640, actually, using `after_commit` would introduce inconsistencies between the database and the search index. This will need some more thorough thinking -- any comments, ideas?

@donaldpiret True! But the way I see it, if you're concerned about the HTTP call inside the `update_index` on each save, you should have a specific indexing strategy, ie. backgrounding...

@jeremygpeterson See the caveat in 38492a5832160642b669630892554c74c7101f5c. I'd like to have a look into the hooks in Tire to make use of the `after_commit`.

Thanks — would it be possible to add a simple integration test for the feature?

Please see the 'tire' proxy in the Readme, Tire doesn't overload any already defined methods. On Tuesday, 9. July 2013 at 17:48, Hugh Brock wrote: > I have code which...