Karl Dubost
Karl Dubost
Could you reopen this issue. This creates web compatibility issue with Firefox on Android. see https://github.com/webcompat/web-bugs/issues/28773
Happy to review.
Confirmed with the current release macOS Sierra 10.12.4 (16E195)
This seems to work now on Firefox. So we could close it.
some experiments, and inspiration https://github.com/leonardr/botfriend/blob/6157a873c4158ccfdda4bf021059bddf14217654/botfriend/feedbridge.py https://github.com/csernazs/misc/blob/b3b4c7d8b40795a0e99480d744e574a04819425a/rssfilter/rssfilter.py which is about basically using [feedparser](https://github.com/kurtmckee/feedparser) to parse and reassign each variables to the feedgen model.
I'm happy to provide a patch. Not today. but next week.
Oh. Indeed you have a dependency on @tobie library. Understood aand @miketaylr already did a patch there. ``` from ua_parser import user_agent_parser ```
This can be closed as FIXED. ``` >>> # Accessing user agent's browser attributes ... user_agent.browser Browser(family='Firefox Mobile', version=(44,), version_string='44') >>> user_agent.browser.family 'Firefox Mobile' >>> user_agent.browser.version (44,) >>> user_agent.browser.version_string '44'...
Not sure why btw https://github.com/selwin/python-user-agents/blob/master/user_agents/parsers.py#L58-L66
Just an old version. ``` python >>> import user_agents >>> user_agents.VERSION (0, 3, 2) ``` Let's close it as Fixed.