Karl Bartel

Results 112 comments of Karl Bartel

If #23 gets done, you might be able pass the expression to the query generator in order to get the whole expression as a string.

Maybe we should not silently discard the error in https://github.com/celo-org/celo-blockchain/blob/85c175776055fc739fb179d9426d7b158e0c3644/miner/block.go#L386

From reading the stack trace, I see only one way to cause the error and that is * Have a `curr` of `nil` in [`toCeloFn`](https://github.com/karlb/celo-blockchain/blob/3a6e0006e2b2f0ce8c937147e33baee7702fd8c7/miner/block.go#L379-L382) * because [`GetExchangeRate`](https://github.com/karlb/celo-blockchain/blob/3a6e0006e2b2f0ce8c937147e33baee7702fd8c7/contracts/currency/currency.go#L206-L225) failed to...

I was unable to reproduce the panic with v1.7.4, but I just ran it locally and didn't use the docker container as described in the issue. We could easily handle...

According to https://github.com/celo-org/celo-blockchain-planning/issues/172#issuecomment-2066858102, we should extract an `IFeeCurrencyDirectory` interface from this contract. I think that should include * getCurrencies * getCurrencyConfig * getExchangeRate * CurrencyConfig If we don't want to...

I also see this problem. However, increasing the `finalizationPeriodSeconds` didn't reduce the lag between L2 block number and the one seen in `L2OutputOracle`'s ` latestBlockNumber`. The proposed L2 block number...

Increasing `l2OutputOracleSubmissionInterval` solves the problem for me.

The test usually succeeds, but according to CircleCI, it is flaky with the [most recent failure 7 days ago](https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/8752/workflows/4c3acfa6-b043-4b47-aa2a-f3563343567c/jobs/92998). If we can trust CircleCI's flakiness detection, we have a high...

I was able to reproduce the same error locally (after running the test many times): ``` --- FAIL: TestSendCelo (0.56s) e2e_test.go:42: Error Trace: e2e_test.go:42 Error: Received unexpected error: failed to...

I've successfully used `geth import` on our current master with mycelo. Should we close this?