Karel Bilek

Add go.mod, go.sum

1

Creating a go.mod/go.sum (note, it's needed just for context, which... is already in standard library...)

x/net/context is not needed for a while now

Add package.json

3

Please add package.json, I cannot use this with npm now

Getting different context in javascript call

1

This might be just a missing feature in the documentation, or a missing feature, I am not sure I want to use different context with gettext directly in code. Such...

Why not use hidraw instead of libusb?

3

Just asking - why does this use libusb instead of hidraw backend? Hidraw seems like less of a hassle (no need to package all libusb), but I have not tried...

Similar to #13, will help with that later

This is a feature request, but I can help working on it later this week (-ish) :) I like your module, will help you with that

Instead of writing custom handlers functions and custom outputs, this should be using protobuf, grpc and json-grpc-gateway

Letting wallets to define failure

2

Instead of guarding insufficient value in simulator, lets wallets themselves define insufficient funds in selectCoins by returning None I needed to tear apart selectCoins and spend for this. TODO: measuring...

Min change as a factor of input cost

1

Instead of just a number, it makes more sense for it to be multiplier of input cost so with larger fees, the min change is larger, with smaller input cost...