karanmehta93
karanmehta93
@BinShi-SecularBird can you fix the conflicts?
@eolivelli @reddycharan Check this out.
> Why do we have to define more constants, one for each supported digest type? The writer already knows the current digest type. How would server know the digestType if...
> On the client API we should only have one WriteFlag CHECKSUM_VERIFICATION, as the LedgerHandle already knows the digest type. I guess that comment is coming based on the fact...
@eolivelli Any comments here? I don't want to merge this now, just get an informal approval.
So if I understand this correctly, we _should_ copy over a writeFlag class to server side, have only 2 flags at the client level. Since the server uses `getWriteFlags()` method...
@eolivelli @sijie Thoughts?
@eolivelli Currently I am not working, busy with some internal stuff. Will update the PR when I get some time.
@eolivelli Apologies for late reply. I tried re-factoring the code but it's seems like a bigger effort. We ended up implementing the code internally in the same way as this...
Are you fine with the approach I have in this PR? @eolivelli If yes, I can bring the other patches in too. If we want to modify the public API...