Daniel Lima issues

Repositories
Issues
Comments

Results 2 issues of


                                            Daniel Lima

Fix: update isAuctionExpired function

Issue: This view function is semantically wrong, the auction is expired only if `endTimestamp` is less than `block.timestamp`. Solution: Fixes operator sign to `=`

isAuctionExpired view function is with wrong return value

The actual function is considering active auctions as expired (if endTimestamp is in the future) ```solidity function isAuctionExpired(uint256 _auctionId) external view onlyExistingAuction(_auctionId) returns (bool) { return _englishAuctionsStorage().auctions[_auctionId].endTimestamp >= block.timestamp; }...