kanwang

Results 11 comments of kanwang

[Core] GCS FT with redis sentinel

@jjyao @rkooo567 would you be able to help review this?

[Core] GCS FT with redis sentinel

hey @rkooo567 gentle ping on this PR.

[Core] GCS FT with redis sentinel

Hey, Gentle ping on this. Could I get some review please? thank you!

[Core] GCS FT with redis sentinel

hey @anyscalesam Any movement here? sorry for keep bugging you guys!

[Core] GCS FT with redis sentinel

Hey team, any chance that we can get this reviewed this week or early next week? Thank you! cc @jjyao

[Core] GCS FT with redis sentinel

hey @jjyao gentle ping on this. thank you!

[Core] GCS FT with redis sentinel

hey @jjyao checking on this again since all tests passed now.

[Core] GCS FT with redis sentinel

Thanks! Addressed the feedbacks.

[Core] GCS FT with redis sentinel

> Have you tested with real Redis Sentinel? Yes, I did test it on redis sentinel locally (with a remote redis sentinel instance). > When we connect to the primary,...

[Core] GCS FT with redis sentinel

Thank you for approving! Looks like all tests passed. Can you help with merging?