Gil Pedersen

Results 191 comments of Gil Pedersen

Yes, just always set a weak etag instead of the `-gzip` (when adding a compressor). I don't believe this will have any adverse effect. The fact that I can provoke...

Afaik, a browser or caching proxy only needs strong ETags when it has a partial response and wants to expand on this using a Range request. For normal caching purposes...

While this is definitely a breaking change (the docs will have to change), I feel that it would be fair to remove such a broken feature on the current release.

I guess you are right. My main concern is that someone might add new code that tries to depend on this. But that is probably quite unlikely.

Hmm… yeah, this does seem strange for hapi to expose `Validate` for run-time validations. Eg. there is no way to localize the generated error. Ideally, hapi would use the passed...

While I expect that reporting the `eventLoopUtilization` could be a useful metric, I feel a `maxEventLoopUtilization` option could be dangerous to use. The point of the "max" limits is to...

Reconsidering this, and I think it is probably useful as just another way to handle some cases of high load.

This could very well be related to #4297, which provides some insight.

I don't see any reason for preflight responses to ever return code `204`, so I would much rather just change it to `200` than introduce another option. The only cost...

The point is that 200 works everywhere, and is likely to continue doing so forever, while 204 can break in some configurations. I don't have much regard for your MDN...