Kanishk Kakar

Results 59 comments of Kanishk Kakar

I'm confused about the discussion here - given that people can now control their notifications across all clients from the web app and we read notifications from the favicon updates,...

If we're planning to also include a similar setting on the desktop app, how does that add more to what's on the web app right now?

> zulip.domain.com / server1.zulip.domain.com - Show d / show s @abhigyank correct me if I'm wrong, but the problem here is just the word `zulip` in the server URL, right?...

Please let me know if any further changes are required here.

I agree, hard coding is a pretty hacky solution. I’m also unsure what we should do. :( On Thu, 4 Apr 2019 at 10:44 PM, Abhigyan Khaund wrote: > but...

@rishig would you mind having a look at this whenever you're free and telling us what you think?

> I think we should just show some kind of error state if the realm doesn't have an avatar set (e.g. a box with a ?). I think that'll be...

@timabbott I'm sorry, I don't understand. What do you mean when you say `sortable.js`? I can't find any file by that name in the repo.

I've been trying to solve the tooltips problem, and I'd like some clarity here: the `initTabs()` method in `app/renderer/js/main.js` calls `initServer()` using the following code: ``` const servers = DomainUtil.getDomains();...