Kanishk Kakar

Results 59 comments of Kanishk Kakar

To update everyone keeping an eye on this PR, there are some problems with `` that cause bugs with the redirection flow in the app. I've not been able to...

> are we planning to work on this after BrowserView PR gets merge? Yeah, I've rechecked the logic for the redirection and the reloading of the `` (controlled by the...

> But that would be confusing if the user isn't using the app Hmm, I'm not sure if I agree with this statement. I'd say that OSes are fairly vocal...

@akashnimare in case we're planning to pick this up this week or so, I can fix the conflicts and work with @manavmehta on this.

> Instead of storing whether org is muted in configutil, I think i'd be better to store that as a property of the org in domain-util.json. I attempted that initially...

@abhigyank the latest commit addresses the refresh problem, but behaviour is undesirable in one case - if the user is on the org preferences page and then mutes an org...

Ah, sorry. Should've checked thoroughly. > Not sure how we can tackle this but I think we can make use of IPCRenderers 'forward-message' feature here. Thanks! I'll check that out.

> What does the setting currently do? The setting hides the number of unread messages in the sidebar and the tray icon for all muted organizations. > Also, I think...