Results 21 comments of Kang Minchul

hello, i want to solve this issue, can i take this one?@ShanmukhaSahiti

If there's anything I can do more, I'll amend this commit right away. Thank you.

I totally agree with @honggyukim :) Thanks.

Thank you :) If this issue is urgent, shall I add coverity scan for github action? Or are you going to add coverity scan soon?

Reference: https://github.com/scop/bash-completion#faq Q. I author/maintain package X and would like to maintain my own completion code for this package. Where should I put it to be sure that interactive bash...

how do you think about this commit then? This one will guarantee bash completion work correctly when `sudo make install`ed or installed by root at least. ``` ifeq ($(shell id...

Ok, I just amended the commit like below ```Makefile # check if prefix of installation location is /usr/ ifeq ($(shell echo $(DESTDIR)$(prefix) | head -c 5),/usr/) # check pkg-config has...

just amended commit for code readability. changed `head` to `cut` ```Makefile # check if prefix of installation location is /usr/ ifeq ($(shell echo $(DESTDIR)$(prefix) | cut -c 1-5),/usr/) # check...

Thanks for reply :) just rebased and amended commit as you mentioned.

i just amend the commit as @namhyung said, and clarified `compldir` path in configure script in simpler way. Thanks for feedbacks!