Gregg Kang issues

Repositories
Issues
Comments

Results 3 issues of


                                            Gregg Kang

Looking up token["ETH"] and checking for supportsAsset("ETH")

This is a low priority issue but something you may want to fix at some point. There should be consistency when looking for the existence of a supported asset and...

Is _windowSize UNIX time or seconds?

https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L48 There seems to be an inconsistency with the comment here and wanted to make sure that it's not an issue in other parts of the code (which I haven't...

Add a require statement

https://github.com/aparnakr/OptionsProtocol/blob/9363067b23278cd6d919cc0dad8ae0d4b489491f/contracts/OptionsFactory.sol#L124 Check if the same asset is being added. Something like: require( tokens[_asset] != ERC20(_addr), ...)