Seungwoo Kang
Seungwoo Kang
@dranikpg It seems capturing reference and invoking 'end()' in another thread also blocks receiving next request. Is there any reference to implement receiving next request before current response is made?
Additionally, what do you think about replacing `websocket::connection::userdata_` field as `shared_ptr` with custom destructor? https://github.com/CrowCpp/Crow/blob/c0bfaa7709fe9698c0989788ddee6c2cdf254043/include/crow/websocket.h#L33-L37 I think userdata assignment logic can be changed into `shared_ptr` implementation without breaking current user...
@dranikpg Thanks to reply. Yet I'm not fully aware of all HTTP upgrade process, it would take some time to find appropriate fix myself. --- @MichaelSB And actually above userdata...
@MichaelSB I totally agree with your view, as this introduces unnecessary overhead in every use cases currently. However, the reason I prefer using `shared_ptr` everywhere is not only for implement...
1. Resolved merge conflict with master branch 2. Resolved compilation warning due to c++14 features
Actually I wanted to write a macro which accepts parameter as `path::Type::ident`, but couldn't retrieve the last token from path. 😢
This is basically to avoid using string literals whenever possible. Since we're generating bindings from rust code, we can benefit from a lot of compile-time information, and the name of...
> please don't edit your initial message in a way that makes the conversation flow hard to follow Apologies for making confusion ... 😢, rolling back again would make another...
Thanks for detailed answer! Following are about initial intentions, and some corrections of myself: --- > Adding hundreds of LoC for a quality-of-life change may not be warranted Agree. I...
Oh Wow, this was exactly what I was looking for and trying to implement on my own from this night. God thanks I tried searching 'dynamic' on issue list and...