Naoki Kanatani comments

Results 59 comments of


                                            Naoki Kanatani

OAuth Slack Token Logged In Clear

Thanks for reporting. As you said in argoproj/argo-events#944, `api.Debugf` writes only if debug mode is enabled. So I think it's not a bug 🤔 What do you think?

OAuth Slack Token Logged In Clear

Okay, it seems good to me. Please send a PR?

OAuth Slack Token Logged In Clear

Thanks!

OAuth Slack Token Logged In Clear

@christophercutajar I'll close it once, but feel free to re-open it or send us a pull request if you want!

OAuth Slack Token Logged In Clear

Thanks @briemarie! I'll confirm later.

Support team.profile.get method

The failure of linter check is caused by golangci-lint's upgrade, so don't worry about this 🙏

Slack app unresponsive every few days, connection from slack to backend sevice lost

Please give me some more details. Do you have any related logs, etc?

remove token from url parameters

This PR doesn't seem to resolve #992. It would also be helpful if you could write a description of the PR.

remove token from url parameters

Umm...this PR doesn't resolve original issue as I mentioned above.(I tried again ,but got same result) However in the master branch, the original issue should be fixed now.

proposal: automatically detects differences from Slack's API

This proposal looks good for me. Do you have any ideas?