kalvdans
kalvdans
> Can you point me to where `hash` is called on a mutable object in mendeleev? Nowhere but other code using the library might start to put elements in a...
The (macos-latest, 3.6) integration test failure looks like an unrelated internet access failure.
A hash algorithm is used in hash tables to allow for constant time average lookup time. It should not be used for anything else. The old implementation of `__eq__` will...
> In your case the calling hash(self.atomic_number) seems redundant. You are right. hash() automatically [truncates integers to machine precision](https://docs.python.org/3/reference/datamodel.html?highlight=truncates#object.__hash__). I will change that, hang on!
> I'm not sure that I agree since python `dict` and `set` operations are based on hashing, so if it's good enough for the standard library it's good enough for...
I care a lot about the quality of the mendeleev package, please tag someone else on the PR to get a third opinion.
@mattwthompson, can you have a look at this PR?
@MatParr, it might be the same issue, but please bring it up in the spydercustomize forums first, since that's where the `runfile` function comes from.
@MatParr Let's continue on email to not put unrelated discussion in this issue, my email is [email protected]
Fixed by #78?