Kai Mast

Results 167 comments of Kai Mast

Looks great to me! I left one comment about potentially loading an outdated cache, which I believe needs to addressed. Additionally, I wonder if we could store the block tree...

#3001 adds version detection to the `RestQuery` logic. This change should resolve problems where users add the version to the URL explicitly.

Have you thought about exposing a simple high-level function, such as `wait_for_next_blocik`, instead? That would avoid having to pick a specific communication mechanism for this feature. > the blocks could...

I was thinking of something very simple, like adding a condition variable (or `tokio::sync::Notify`) to `Ledger`. There is already a lock around [`current_block`](https://github.com/ProvableHQ/snarkVM/blob/ce07a2c8edc5f5125b3cc6edac9f920b55b9ca5c/ledger/src/lib.rs#L139). Whenever `current_block is updated, you could call...

I think we should document what functionality the new feature enables somewhere. You could use [this README change](https://github.com/ProvableHQ/snarkVM/blob/1d3147e1d5dae4e84cbad8157dc4ad2d69c1d2f8/README.md#21-feature-flags) from the `tracing` PR as a basis. You might want to add...

What is the rationale for not returning an error on invalid port numbers?

> It probably should return an error when the Uri/Authority itself is parsed, not when calling the accessor. That is what I meant