Kai Mast

Results 167 comments of Kai Mast

There's a [proposed Rust feature](https://github.com/rust-lang/rust/issues/89554) that lets you address that `#[deny(non_exhaustive_omitted_patterns)]`. Maybe we can revisit this proposal when that feature makes it into stable Rust.

I also see these warnings in benchmark runs ``` warning: unused variable: `expected_size` --> parameters/src/macros.rs:364:21 | 364 | let expected_size: usize = | ^^^^^^^^^^^^^ help: if this is intentional, prefix...

I have had issues like this too, but mostly during compilation. What I usually did is reduce the number of concurrent build jobs or tests. It would be nice to...

> Related: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.20. They indeed removed this feature in a patch release. Other projects seem to run into the same issue as us: https://github.com/tokio-rs/tracing/issues/3378

It doesn't seem to be related to this PR, but there was a regression after merging #2789. I will investigate...

Aren't panics fine inside `try_vm_runtime`, or are there possible side effect we are worried about?

@vicsn I added a short motivation to the PR description.

I think there are ways to generate similar graphs with tracing. However, I should be fine to keep both for now, and we can revise it later.

@vicsn I extended the PR description

Do you have CUDA installed on that machine, and does it have a GPU that supports CUDA?