Andrew Huang

Results 21 comments of Andrew Huang

I've actually implemented a fix for this in https://github.com/python-hyper/hyper-h2/pull/1185

For sure, let me know if there's anything I can help to clarify

@pgjones anything that I can do to help push this along? Currently using my fork in production, which is making tens of millions of http2 requests/day, but would prefer switching...

On the *old* code, here is how `test_concurrent_stream_open_performance` runs: ``` ============================================================= FAILURES ============================================================= ___________________________ TestConcurrentStreamOpenPerformance.test_concurrent_stream_open_performance ____________________________ self = frame_factory = def test_concurrent_stream_open_performance(self, frame_factory): """ Opening many concurrent streams is constant...

So the lints I can clean up (I assume I can just run autopep8 or something similar?), but the code coverage tests are failing for some versions of python for...

Oh I see, it's because the if() never evaluates to False. If I remove the conditional the coverage tests pass The reason that conditional is there is for defensive reasons....

@Lukasa @pgjones This is ready for review (picking these names based on recent merge commits)

> Thanks for your contribution. Can you explain why you want to return the updated document? If there was no error the operation succeed and the changes have been applied....

These are great points. This diff was originally for a private fork before we had introduced any clients, so there was no risk of backward incompatibility issues What I've done...