Kagaya

Results 9 comments of Kagaya

Hi @jeffcaiz, I think it is a bug, because of we store all config value as a `string` type in a `map[string]interface{}` struct, when we try to load config value...

> If the user really just want a string, they should quote with single quotation mark. I am glad to see `CustomResolver` solve this problem temporarily. We can consider about...

可以参考一下 bindings 和 pubsub 的接口设计 * https://github.com/dapr/components-contrib/tree/master/bindings * https://github.com/dapr/components-contrib/tree/master/pubsub

Thanks for your contribution, one suggestion, it's a good idea to add some description about this PR for reviewers to review :) fix #1565

> Hey, @kagaya85 ,thanks for your suggestion. The resolveTable could generated by following: > > ```go > var resolveTable = make([]byte,256) > // Sign > resolveTable[int('+')] = 'S' > resolveTable[int('-')]...

感谢建议,目前watch的设计可以监听到新增和修改,对于删除的key的场景确实没有考虑到使用基础值补充的情况,我先标记一下可以讨论一下具体的实现方式

感谢建议,我认为默认设置提供的信息可以帮助的很多刚开始上手框架的朋友,应该予以保留。在该问题场景下是否可以通过设置filter来过滤指定level的日志: https://github.com/go-kratos/kratos/blob/617ee1aa39a09f1b93ce246d7a569e30605690fd/log/filter.go#L9-L13 另外也可以尝试在初始化时替换全局默认Logger为自己实现的Logger来避免意外的日志输出。

Hi there,我可以帮忙尝试实现一下收藏部分的api,这几天抽空理解了下代码和文档,感觉可以开始上手了,有什么其他建议可以帮助我展开工作吗😃