kadarakos

The very general structure for this I think is the Interval Tree right? https://en.wikipedia.org/wiki/Interval_tree

Please allow me to ask this :trollface: question. Isn't the `store_activations` mechanism kind of a temporary stand-in for a more general `GlobalListener` that is kinda like an `ActivationPool` that components...

> > Please allow me to ask this :trollface: question. Isn't the `store_activations` mechanism kind of a temporary stand-in for a more general `GlobalListener` that is kinda like an `ActivationPool`...

> Why isn't `column` implemented in the model in the same way as in `HashEmbed`? How is it different?

> Both `HashEmbed` and the PR description look more like this: > > https://github.com/explosion/thinc/blob/40c129f6ee51d4060f1af6b29f903ce51fd89736/thinc/layers/hashembed.py#L48-L53 > > It's not that I think the output here is incorrect, but I'm trying to...

> Ah, I see what you mean. I was mainly thinking that implementing this the same way would avoid a lot of the casting and numpy/cupy problems. > > In...

> I think that sounds reasonable. Added the new version.

> This version looks good! It does change the parameters and types enough that I think it should be `remap_ids.v2`, though. I think we can just have both in parallel...

> I agree that the existing version is wonky, but the main issue is the parameters, since this removes `dtype` and adds `column`. If you hadn't removed the existing test...

So yeah I guess I find it a bit hard to understand what should I include in `.v1`