Kenichi Kamiya
Kenichi Kamiya
Run eslint with existing config makes many non related alerts. I have updated them. However when the diff is needless, I'll revert them. (Looks CI is not checking them) 🙏
@brphelps Sure! I have updated this PR for focusing multiple license issue. And extracted CI and lint in following PR https://github.com/kachick/dependency-review-action/pull/1 I can send it after this PR closed.
I couldn’t imagine reasonable specs for a denying condition and a given combining condition. 🤔 For example, below patterns. Allow License | Deny License | Given License | They should...
Thanks for your comment! >I think we are not doing the bold parts. Agreed, and I think **ignoring them** is the desirable spec for actual use-case, rather than strict following...
Thanks for your review! I'll check and update. Temporally make be draft state. 🙇
Thanks for your review! >moving it to a separate directory, e.g., ts-tests, and adding a different command to run it, e.g., npm run ts-test How about this change? https://github.com/uhop/node-re2/pull/134/commits/e380c1879074f75604bbb26639248abc3574dacb
Sorry for my late response 🙇♂️ Looks updating this issue with https://github.com/actions/dependency-review-action/pull/294. And this PR based on outdated code now. So please close this PR for now.
``` inseting -> inserting ```
This does not seem to be just an `update-type` problem, but a whole version extraction problem. ```text outputs.previous-version: outputs.new-version: ``` This action extracts versions from the default commit message, but...