Ken Domino
Ken Domino
I'll work on a PR fix later today.
Actually, this requires modifications that I'm not the best to do. The grammar has several problems: * a "symbol conflict" with "start" for Go; * a "symbol conflict" with "base"...
I have a few observations and questions. * I've been writing target-agnostic Antlr grammars probably more than most, porting grammars-v4 to different targets, pretty much every day of the week...
Usually, I would say that ST should be supported outside the tool, but after thinking about this a bit, I think you are right. The main reason why it should...
Semantic predicates are actions, too. It's not expanding template references there, but it is working elsewhere. ``` header() ::= > action1() ::= > pred() ::= action2() ::= > ``` ```...
Looks like you need to test for SEMPRED in addition to ACTION in `expandActionTemplates(GrammarRootAST root)`. Then, trim the extra '?' from the text of the predicate. Honestly, I don't understand...
The problem with writing the grammar as STG-format file is that it is then not an Antlr grammar. The format could not be parsed using the grammars-v4 antlr4 grammar. Existing...
> Making it a grammar option ( using `options { actionTemplates='Temp.stg'; }` ) pushes the responsibility of locating that template to antlr, which is wrong. Well, I could solve the...
> there is a big downside to this which relates to automation. Many developers use the maven plugin to generate code at build time (rather than at dev time -...
> @kaby76 Sorry to disagree, but that would have to be a new entry in the pom file. I am not supportive of an approach that requires the tool to...