Ken Domino

Results 839 comments of Ken Domino

When I go to the link you provide (https://protobuf.dev/programming-guides/proto2/#extensions), the very first extensions example (https://protobuf.dev/programming-guides/proto2/#ext-example) is this: ``` // file kittens/video_ext.proto import "kittens/video.proto"; import "media/user_content.proto"; package kittens; // This extension...

> Yeah, but that's not really relevant for this issue is it? I can raise another ticket for the syntax tag if you lilke (but I think the Google docs...

> I already included an example with the PR. Isn't that part of this conversation a needless duplicate of the comments there? If it's there, great. I will review it....

The problem becomes apparent if you remove `modifier*` from the alt [| modifier* memberDeclaration](https://github.com/antlr/grammars-v4/blob/a5754dd907b434d161213b729178c8fbbd128c2c/java/java/JavaParser.g4#L145) and then parse this: ``` class Test { @ApiModelProperty(value = "x") @XmlElement AdditionalParams additionalParams; } ```...

I now remember why I punted on making `` an empty element. This is because the Antlr Maven tester so old that it cannot test only the files `examples/*.proto`. By...

There's something wierd about the EOF in closures that's not being checked consistently. ``` $ cat Eh.g4 grammar Eh; start : eh+ EOF; eh : 'eh?' | EOF; WS :...

I'm thinking that this should be implemented via a shared .g4 grammar, which is `import`-ed. As far as I can tell, the Text Format Language Specification is not versioned.

See https://github.com/antlr/grammars-v4/pull/4638.

You might want to check the ambiguity and parse tree result for some of your tests. Here are all the possible parse trees for select.sql. ``` ../examples/select.sql.d=177.a=1: (sqlCommandList (cmd (queryOrSubquery...

@teverett Please consider merging this PR. Maven Central is not a reliable service for downloading the Antlr Tool jar during a build because it treats the downloads as a DOS...