Ken Domino

Results 839 comments of Ken Domino

The grammars in [grammars-v4/python/](https://github.com/antlr/grammars-v4/tree/master/python) are a mess. This should be cleaned up in "target-independent" format, which means [this](https://github.com/antlr/antlr4/blob/master/doc/python-target.md#target-agnostic-grammars), plus organizing the target-specific code in CSharp/, Java/, Go/, Python3/, Python2/, Dart/,...

> Can you help me to understand why the first argument is _Python3_ and not _Python3Parser_ (as is the name in Python3Parser.g4)? The code that is executed, [here](https://github.com/antlr/antlr4/blob/23f93e0d1b4254728e73fbf529babfde3caf72c3/tool/src/org/antlr/v4/gui/TestRig.java#L125), computes the...

This is not an error in the grammar. [trgen](https://github.com/kaby76/Domemtech.Trash/tree/main/trgen) generates a working parser for targets Java and CSharp. The problem is an error in setting up the IDE: if you...

Please also remove [the "php" line from the skip-python3.txt file](https://github.com/dkazantzas/grammars-v4/blob/4d1a0dc07d8c05e14df681cd10a7034bc74650a2/_scripts/skip-python3.txt#L63). The file tells the build script to "skip" doing the build for the "php/" grammar. When the line is removed,...

Almost there. * The directory php/Python/ should be renamed php/Python3/. There really isn't a "Python" target, but either "Python2" or "Python3". The build script checks for the directory corresponding to...

@teverett This PR is okay--good changes. The build failed with the usual "Connection closed before full header was received" in Dart only. Not sure what to do about these Dart...

> @kaby76 thanks. Let's fix the Dart issue before it gets pulled. @teverett I created a Github Issue for this https://github.com/antlr/grammars-v4/issues/2743 As I explained there, we've been getting a "Connection...

@teverett Thanks. It happened again. I'll check it out locally on my machines to see what I can do.

@teverett [I created a PR to wrap the "dart pub get" in a loop to repeat on error](https://github.com/antlr/grammars-v4/pull/2744). It doesn't hurt the build, may help in these dart connection drops,...

@dkazantzas Please fast forward your repo so it can be rebuilt.