Ken Domino

icon location United States icon location No one cares about my bio. But for what its worth, I have been programming since the early 1970s, pretty much everyday.

Results 839 comments of Ken Domino

C++: Too many ATNConfig Allocations

`foo + bar`. This could be parsed two ways: `expr` => `ID + ID` (binary operator) vs `expr` => `func_call + ID` =>+ `ID + ID`. Do you or not...

Feature: Fragment Parser Rules

This can also be done using Trash ([trparse](https://github.com/kaby76/Domemtech.Trash/tree/main/src/trparse) and [trunfold](https://github.com/kaby76/Domemtech.Trash/tree/main/src/trunfold)) of the `xFields` rule prior to code generation. ``` 01/07-17:34:02 ~/issues/antlr4-4505 $ cat g.g4 grammar g; x: OPEN_BRACE xFields (COMMA...

TestRig exports invalid SVG

We don't know what your input is. Please provide an input string.

[Go target] Antlr Visitor does not work properly

https://groups.google.com/g/antlr-discussion/c/gEiAPs-XGps I cannot see how this person's code targeted for Go can work whatsoever. I have not replied there because the Google Antlr Discussion Group is only for announcements (but...

[Go target] Antlr Visitor does not work properly

@cwarden That example illustrates my point. Every single production in the grammar requires an implementation of the visit function. If you do not implement the `VisitStart()` function, then the expression...

[Go] Fix for #3441 and #3443 -- expose Reset() and String() methods.

Waiting for https://github.com/antlr/antlr4/pull/3558

C# runtime: use is operator with declaration where possible

I cloned and built [antlr4 CSharp dev branch](https://github.com/antlr/antlr4/tree/dev/runtime/CSharp/src) and [Ivan's mod branch](https://github.com/KvanTTT/antlr4/tree/csharp-use-is-operator-with-declaration)--both Release config, then took [java/java](https://github.com/antlr/grammars-v4/tree/master/java/java), generated both a CSharp and Java driver using trgen, built the CSharp driver...

C# runtime: use is operator with declaration where possible

I repeated mulltiple times the testing of this PR against: (1) [the java grammar](https://github.com/antlr/grammars-v4/tree/master/java/java) with input a generated JavaParser.java from the grammar; (2) the [the golang grammar](https://github.com/antlr/grammars-v4/tree/master/golang), input /map_with_string.go, on...

PHP package numbers should be identical to the version for Antlr.

I am planning to re-add the testing of PHP targets for grammars-v4, fixing https://github.com/antlr/grammars-v4/issues/3125 I have a workaround that finds the tool version that corresponds to the Antlr PHP runtime...

Warm-up really doesn't help much, if anything at all, in performance

~~Looks like out of the gate of the start of the parse, the first call to [GetCachedContext()](https://github.com/antlr/antlr4/blob/76fa05c21b12b96a6c12a0a82e611ed9d87d5af4/runtime/CSharp/src/Atn/PredictionContext.cs#L401) should be for an empty context ("$"), breaking [here](https://github.com/antlr/antlr4/blob/76fa05c21b12b96a6c12a0a82e611ed9d87d5af4/runtime/CSharp/src/Atn/PredictionContext.cs#L405).~~ ~~But, that's not the...