Ken Domino

icon location United States icon location No one cares about my bio. But for what its worth, I have been programming since the early 1970s, pretty much everyday.

Results 839 comments of Ken Domino

javascript cpp port crashes when parsing a js file

> Is it related to this bug I added [antlr/antlr4#3845](https://github.com/antlr/antlr4/issues/3845) ? Yes, it ooks similar. The code is trying to compare two null array ptrs of predition context. I tried...

javascript cpp port crashes when parsing a js file

> Yep, that sounds right. I gave up on trying to fix that bug when adding a print (cout) statement caused literally hundreds of lines of error messages to come...

javascript cpp port crashes when parsing a js file

Try adding this [before this line](https://github.com/antlr/antlr4/blob/aa1f1f12a846846fcb78544bdb2ad135471376db/runtime/Cpp/runtime/src/atn/ArrayPredictionContext.cpp#L25). ``` if (lhs == nullptr && rhs == nullptr) return true; if (lhs == nullptr && !(rhs == nullptr)) return false; if (!(lhs ==...

javascript cpp port crashes when parsing a js file

Yeah, the regression tests for the grammar aren't all passing.

javascript cpp port crashes when parsing a js file

The Cpp target for the javascript/javascript was incorrectly translated in the port from Java to Cpp. This test is wrong: https://github.com/antlr/grammars-v4/blob/c4775c1c07ef227055682c65cece28add2233782/javascript/javascript/Cpp/JavaScriptLexerBase.cpp#L62 Original commit with the bogus test: https://github.com/antlr/grammars-v4/commit/6a5d54769dbd541ef28a3a7f4b3f72108da1b64f#diff-6ba0edd9b0fa999f7902f8f2c153d4bd2b9cde2f4ee1b1314a227213426b6c1dR55 Contrast this...

javascript cpp port crashes when parsing a js file

There are a couple of the same errors with `lastToken` in the Cpp port, where `lastToken == null` was rewritten erroneously `lastToken`. Fixing these, the parser works now fine. One...

Build is very slow, tests too much, outputs too much

Let's take a concrete example. https://github.com/antlr/grammars-v4/pull/2987 This PR changed just four files https://github.com/antlr/grammars-v4/pull/2987/files all in the java/java directory. The Github Action spawned was https://github.com/antlr/grammars-v4/actions/runs/3824038534/ This action took the usual 2...

Build is very slow, tests too much, outputs too much

* The CSharp target takes over an hour to test everything. The main reason is that the C# compiler is *really slow*. Perhaps we should skip most of this and...

Build is very slow, tests too much, outputs too much

There are really a few strategies for setting the set of grammars to test: * Test "git diff" changed grammars from some "previous" * Test target in which there is...

Build is very slow, tests too much, outputs too much

In addition to the slow build, the output is just way over the top too much. The only time we need any output is when there is a build or...