kaarrot
kaarrot
Squashed and signed-off.
> The failures above occur on systems with libpng v1.5 installed, which are initially detected as too-old; but are later "refound" after find_package fails to find the libraries... @zachlewis, I...
> What do you think about adding `PATHS ${pkgname}_LOCAL_INSTALL_DIR NO_DEFAULT_PATH` I run a quick test replacing `${${pkgname}_REFIND_VERSION} REQUIRED` with: ``` find_package (${pkgname} ${_pkg_UNPARSED_ARGUMENTS} ${${pkgname}_REFIND_ARGS} PATHS ${${pkgname}_LOCAL_INSTALL_DIR} NO_DEFAULT_PATH) ``` Sadly, this...
> The failures occur when the build system detects a too-old version of libpng: > 1. Build PNG locally with build_PNG.cmake > 2. Fail to find "our" locally-built libpng >...
> I've been fooling around with this myself. No matter what I do, it's explicitly including the system libpng.so. I'm starting to wonder if some other dependency is pulling it...
> I will push some minor changes on top of your commits, if that's ok with you? Perfect, yes please go ahead.