OpenImageIO icon indicating copy to clipboard operation
OpenImageIO copied to clipboard

BUILD_MISSING_DEPS - fix minor configuration options

Open kaarrot opened this issue 1 year ago • 2 comments

Description

Address a few small issues encountered during CMake configuration step and during build using Makefile BUILD_MISSING_DEPS option enabled.

  • Mismatch between expected libraw versions specified in build_libraw.bash 0.21.3 and externalpackages.cmake 0.20.0
  • OpenEXR link error in libutil tests
  • Update top level Makefile to accept BUILD_MISSING_DEPS as string instead of bool. Pass the string option down to CMake

Test

Verified build completes with no errors: BUILD_MISSING_DEPS=all make

kaarrot avatar Oct 15 '24 20:10 kaarrot

This all looks great, I think the only missing piece is that one or more of your commits lacks the DCO signoff. Maybe the easiest fix is to squash your comments and make sure the one remaining commit has the proper sign-off info?

lgritz avatar Oct 18 '24 21:10 lgritz

Squashed and signed-off.

kaarrot avatar Oct 20 '24 02:10 kaarrot