Norman Hooper

Results 29 comments of Norman Hooper

Closing because associated work items have been closed.

> this can be done into separate PRs Cool. For the sake of keeping review comments in one place, I'll split out a second PR once all feedback is complete.

It was just pointed out to me that [the Jira ticket for this PR](https://dimagi.atlassian.net/browse/SC-3872) is the last one holding us back from wrapping up [its epic](https://dimagi.atlassian.net/browse/SC-3889). Are there any outstanding...

Part One PR here: https://github.com/dimagi/commcare-hq/pull/36581

Closing this PR. Closing [SC-3872](https://dimagi.atlassian.net/browse/SC-3872?focusedCommentId=388674) as "Won't do". See [the ticket comments](https://dimagi.atlassian.net/browse/SC-3872?focusedCommentId=388674) for more context. [SC-3872]: https://dimagi.atlassian.net/browse/SC-3872?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

I think there are two main things happening here: (In reverse order) the second thing is that our perceptions of the value of type hints are different. I can address...

I like this example. And I agree with a lot of the conclusions you draw from it. It could be that this is a useful data point of a function...

Thank you for the input @joxl. I have been worrying that I'm not giving enough weight to the "it will make things (even) messier" side of the conversation. So I...

I don't want to suggest that your concerns about inconsistency are invalid. The real problem here could be that Dimagi devs don't apply principles consistently. That's outside the scope of...

> I'm not going to suggest what you do with your spare time Yeah. That was a little presumptuous of me. > I also did not want to force anyone...