Keith Wall

Split up MultiTenantIT test

3

The test case has gotten big. It'd be better if we has separate ITs focusing on separate concerns (transactions, groups etc) with some sensible sharing of common utility methods.

**Is your feature request related to a problem? Please describe.** In Kafka ACL rules are written in terms of kafka resource names, such as topic name and group names. For...

Introduce marker interface for sensitive material (keys, passwords etc)

1

I do wonder if we should have a marker interface or a record called `Password` to serve as a reminder that we are dealing with sensitive material and keep it...

Expose liveness/readiness probes suitable for Kubernetes

1

If you have questions before creating this feature request, you can use the [GitHub Discussions](https://github.com/kroxylicious/kroxylicious/discussions) or use the [community Slack](https://kroxylicious.slack.com) chat. **Is your feature request related to a problem? Please...

Support alternative sources for password/secrets

1

**Is your feature request related to a problem? Please describe.** Kroxylicious configuration sometimes needs secrets, for example, keystore password and key passwords. We currently allow these secrets to be either...

testsuite/docker/kerberos/config.sh:3:4: error[SC2078]: This expression is constant. Did you forget a $ somewhere?

1

https://github.com/strimzi/strimzi-kafka-oauth/blob/229daee85b096804d16e2904c8c0f1add599cc99/testsuite/docker/kerberos/config.sh#L3 Snyk flags this error, which does indeed look like a true positive. ``` Error: SHELLCHECK_WARNING: testsuite/docker/kerberos/config.sh:3:4: error[SC2078]: This expression is constant. Did you forget a $ somewhere? # 1|...

examples/docker/kafka-oauth-strimzi/kafka/oauth.sh:101:44: warning[SC2050]: This expression is constant. Did you forget the $ on a variable?

1

https://github.com/strimzi/strimzi-kafka-oauth/blob/229daee85b096804d16e2904c8c0f1add599cc99/examples/docker/kafka-oauth-strimzi/kafka/oauth.sh#L101 Snyk noticed this error, which does indeed look like a true positive. ``` Error: SHELLCHECK_WARNING (CWE-398): examples/docker/kafka-oauth-strimzi/kafka/oauth.sh:101:44: warning[SC2050]: This expression is constant. Did you forget the $ on a...

Githib Action workflow logs 'You are using an older version of GraalVM or Mandrel : 23.0.4.1. Quarkus currently supports 23.1.0. Please upgrade to this version'

1

[INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] Running Quarkus native-image plugin on MANDREL 23.0.4.1 JDK 17.0.11+9 Warning: [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] You are using an older version of GraalVM or Mandrel : 23.0.4.1. Quarkus currently supports 23.1.0. Please...

Fix #1415: Improve record validation docs

1

### Type of change _Select the type of your PR_ - Documentation ### Description _Please describe your pull request_ ### Additional Context _Why are you making this pull request?_ ###...

Consider removing upper bound check in KafkaRequestDecoder#readAcks

1

I wonder if we should drop the version check here and rely on the unit tests to check we can extract acks successfully. The test already runs through all known...